Skip to content

Update release notes and pr check actions #4417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thehomebrewnerd merged 2 commits into from
May 10, 2024
Merged

Update release notes and pr check actions #4417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9d7138
update release notes and pr check actions
May 10, 2024
0e084d4
update release notes
May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull_request_check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
name: pull request check
runs-on: ubuntu-latest
steps:
- uses: nearform/github-action-check-linked-issues@v1.4.5
- uses: nearform-actions/github-action-check-linked-issues@v1.4.5
id: check-linked-issues
with:
exclude-branches: "release_v**, backport_v**, main, latest-dep-update-**, min-dep-update-**, dependabot/**"
Expand Down
16 changes: 10 additions & 6 deletions .github/workflows/release_notes_updated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,24 +15,28 @@ jobs:
ref: ${{ github.event.pull_request.head.ref }}
repository: ${{ github.event.pull_request.head.repo.full_name }}
- name: Debug PR type
env:
REF: ${{ github.event.pull_request.head.ref }}
run: |
if [[ $(expr match "${{ github.event.pull_request.head.ref }}" "release_v[0-9.]\+") -gt 0 ]]; then
if [[ $(expr match "$REF" "release_v[0-9.]\+") -gt 0 ]]; then
echo This is a release PR;
elif [[ $(expr match "${{ github.event.pull_request.head.ref }}" "latest-dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then
elif [[ $(expr match "$REF" "latest-dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then
echo This is a latest dependency update PR;
elif [[ $(expr match "${{ github.event.pull_request.head.ref }}" "min-dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then
elif [[ $(expr match "$REF" "min-dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then
echo This is a minimum dependency update PR;
else
echo This is a regular PR;
fi
echo "PR #: ${{ github.event.number }}"
- name: Release notes added
env:
REF: ${{ github.event.pull_request.head.ref }}
run: |
if [[ $(expr match "${{ github.event.pull_request.head.ref }}" "release_v[0-9.]\+") -gt 0 ]]; then
if [[ $(expr match "$REF" "release_v[0-9.]\+") -gt 0 ]]; then
exit 0;
elif [[ $(expr match "${{ github.event.pull_request.head.ref }}" "latest-dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then
elif [[ $(expr match "$REF" "latest-dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then
exit 0;
elif [[ $(expr match "${{ github.event.pull_request.head.ref }}" "min-dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then
elif [[ $(expr match "$REF" "min-dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then
exit 0;
fi
cat docs/source/release_notes.rst | grep ":pr:\`${{ github.event.number }}\`"
1 change: 1 addition & 0 deletions docs/source/release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Release Notes
* Documentation Changes
* Testing Changes
* Run airflow tests in Python 3.9 :pr:`4391`
* Update GH actions to improve handling of potentially unsafe variables :pr:`4417`

.. warning::

Expand Down