Remove things related to vowpalwabbit#4427
Merged
MichaelFu512 merged 12 commits intomainfrom May 21, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4427 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 357 352 -5
Lines 39973 39805 -168
=======================================
- Hits 39849 39682 -167
+ Misses 124 123 -1 ☔ View full report in Codecov by Sentry. |
MichaelFu512
changed the title
MichaelFu512
commented
May 20, 2024
| # It should be len(all_native_components) - num_invalid_for_pd_fast_mode | ||
| if ProphetRegressor not in all_native_components: | ||
| expected_num_valid_for_pd_fast_mode = 65 | ||
| expected_num_valid_for_pd_fast_mode = 62 |
Contributor
Author
There was a problem hiding this comment.
codecov says this line isn't covered by test (and the check for codecov fails as well) if I don't include line 947-948.
jeremyliweishih
approved these changes
May 20, 2024
eccabay
approved these changes
May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #4419
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.