Conversation
added 2 commits
March 24, 2023 13:10
added 2 commits
March 24, 2023 13:33
Codecov Report
@@ Coverage Diff @@
## main #2527 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 379 379
Lines 22549 22550 +1
=======================================
+ Hits 22426 22427 +1
Misses 123 123
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rwedge
reviewed
Mar 27, 2023
Contributor
rwedge
left a comment
rwedge
left a comment
There was a problem hiding this comment.
Maybe we should add a simple test that verifies the commutative parameter for SubtractNumeric is working as intended
ozzieD
approved these changes
Mar 27, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2526