Add MaxCount, MedianCount, MaxMinDelta, NUniqueDaysX, NMostCommonFrequency, IsFirstWeekOfMonth#2533
Merged
Add MaxCount, MedianCount, MaxMinDelta, NUniqueDaysX, NMostCommonFrequency, IsFirstWeekOfMonth#2533
Conversation
dvreed77
reviewed
Apr 6, 2023
featuretools/tests/primitive_tests/aggregation_primitive_tests/test_agg_primitives.py
Show resolved
Hide resolved
featuretools/tests/primitive_tests/aggregation_primitive_tests/test_agg_primitives.py
Show resolved
Hide resolved
Contributor
|
Should mention pinning pandas in the release notes |
Codecov Report
@@ Coverage Diff @@
## main #2533 +/- ##
==========================================
+ Coverage 99.45% 99.46% +0.01%
==========================================
Files 379 389 +10
Lines 22550 22999 +449
==========================================
+ Hits 22427 22876 +449
Misses 123 123
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dvreed77
reviewed
Apr 6, 2023
| primitive = MaxMinDelta | ||
| array = pd.Series([1, 1, 2, 2, 3, 4, 5, 6, 7, 8]) | ||
|
|
||
| def test_max_min_delta(self): |
Contributor
There was a problem hiding this comment.
Interested to see what happens with Inf values?
dvreed77
approved these changes
Apr 6, 2023
Contributor
dvreed77
left a comment
There was a problem hiding this comment.
Looks good besides checking infinite values in max-min primitive
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.