Skip to content

Fix bug in PercentTrue primitive#2627

Merged
thehomebrewnerd merged 5 commits intomainfrom
fix-percent-true-2
Oct 25, 2023
Merged

Fix bug in PercentTrue primitive#2627
thehomebrewnerd merged 5 commits intomainfrom
fix-percent-true-2

Conversation

@thehomebrewnerd
Copy link
Copy Markdown
Contributor

Pull Request Description

Fix bug with default value in PercentTrue primitive

Closes #2625

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f98704f) 99.47% compared to head (4c774c2) 99.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2627   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files         403      404    +1     
  Lines       24201    24214   +13     
=======================================
+ Hits        24074    24087   +13     
  Misses        127      127           
Files Coverage Δ
...ls/primitives/standard/aggregation/percent_true.py 100.00% <100.00%> (ø)
...s/aggregation_primitive_tests/test_percent_true.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehomebrewnerd thehomebrewnerd merged commit a622f62 into main Oct 25, 2023
@thehomebrewnerd thehomebrewnerd deleted the fix-percent-true-2 branch October 25, 2023 16:17
@thehomebrewnerd thehomebrewnerd mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PercentTrue calculation can fail on BooleanNullable inputs when there are no values to aggregate

3 participants