Fixes for holidays version >= 0.33.0#2636
Merged
thehomebrewnerd merged 3 commits intomainfrom Dec 6, 2023
Merged
Conversation
added 2 commits
December 6, 2023 16:12
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2636 +/- ##
==========================================
- Coverage 99.47% 99.47% -0.01%
==========================================
Files 404 404
Lines 24214 24204 -10
==========================================
- Hits 24087 24077 -10
Misses 127 127 ☔ View full report in Codecov by Sentry. |
thehomebrewnerd
requested review from
cp2boston,
gsheni,
sbadithe and
tamargrey
gsheni
approved these changes
Dec 6, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates tests for compatibility with versions of
holidaysnewer than0.33.0.Fixes #2621