Source prop can include http request headers on android.#50
Merged
alwx merged 3 commits intoalwx:masterfrom Jun 22, 2017
Merged
Source prop can include http request headers on android.#50alwx merged 3 commits intoalwx:masterfrom
alwx merged 3 commits intoalwx:masterfrom
Conversation
This is in line with the corresponding change for react-native's Image component in 0.43. facebook/react-native#12448
make the event names in `ImageEvent#eventNameForType` different from the ones used by the core React Native `Image` component. This fixes an issue where `Image` components do not trigger `on*` callbacks because the event name has been overwritten by `PhotoView`.
deconflict ImageEvent event names with core RN
|
@alwx Can you review & accept this pull request? Currently react-native-photo-view for iOS already supported custom HTTP headers but android is not. |
Owner
|
Sorry for the delay. |
Owner
|
Thank you very much, @dxiao |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #49
This is in line with the corresponding change for react-native's
Image component in 0.43.
facebook/react-native#12448