Update retrieving database config hash for Rails >= 6.1#70
Closed
JuanitoFatas wants to merge 4 commits intoamatsuda:masterfrom
Closed
Update retrieving database config hash for Rails >= 6.1#70JuanitoFatas wants to merge 4 commits intoamatsuda:masterfrom
JuanitoFatas wants to merge 4 commits intoamatsuda:masterfrom
Conversation
Rails 6.1 changed the way to retrieve the database config hash to DatabaseConfigurations#configs_for(env_name: "test").configuration_hash The old way will stop working in Rails 6.2. DEPRECATION WARNING: [] is deprecated and will be removed from Rails 6.2 (Use configs_for) (called from create_cleaner at lib/database_rewinder.rb:19) DEPRECATION WARNING: DatabaseConfig#config will be removed in 6.2.0 in favor of DatabaseConfigurations#configuration_hash which returns a hash with symbol keys (called from get_cache_key at lib/database_rewinder.rb:87)
JuanitoFatas
commented
Mar 16, 2020
lib/database_rewinder.rb
Outdated
| end | ||
|
|
||
| def get_config_from(connection_name) | ||
| if Gem::Version.new(Rails.version) >= Gem::Version.new("6.1.0.alpha") |
Contributor
Author
There was a problem hiding this comment.
@eileencodes Should we check configs_for change for Rails 6.0 or 6.1? I found the refactoring introduced in rails/rails#32274 which says v6.0.0.beta1.
There was a problem hiding this comment.
configs_for has been available since 6.0. The hash implementation will be removed in 6.2.
takkanm
reviewed
Oct 15, 2020
takkanm
added a commit
to takkanm/database_rewinder
that referenced
this pull request
Oct 17, 2020
`ActiveRecord::Base.configurations` in edge rails returns Symbol key. And I watched the following discussion. amatsuda#70 (comment) I was referring to this comment as well.
Closed
Co-authored-by: Mitsutaka Mimura <takkanm@gmail.com>
crigor
reviewed
Jan 4, 2021
Comment on lines
+86
to
+87
| if Gem::Version.new(Rails.version) >= Gem::Version.new("6.0.0") | ||
| database_configuration.configs_for(env_name: connection_name).first.configuration_hash |
There was a problem hiding this comment.
configs_for is available on Rails 6.0 but configuration_hash is only available on Rails 6.1. This causes the error on the build.
crigor
reviewed
Jan 4, 2021
| def get_cache_key(connection_pool) | ||
| if connection_pool.respond_to?(:db_config) # ActiveRecord >= 6.1 | ||
| connection_pool.db_config.config | ||
| if Gem::Version.new(Rails.version) >= Gem::Version.new("6.0.0") |
There was a problem hiding this comment.
Do we need this check? The line above already checks for ActiveRecord >= 6.1. In any case, configuration_hash is only available on Rails 6.1.
|
@JuanitoFatas How's it going this pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow I missed this one in #67. Changed the way to retrieve the database config hash because the old way will stop working in Rails 6.2.
This PR fixes following warnings:
@eileencodes Does this look good to you? Thanks!