Skip to content

Comments

Add support for deployment.environment.name#329

Merged
mxiamxia merged 1 commit intoamazon-contributing:aws-ocb-devfrom
blairhyy-amazon:aws-ocb-dev
Jul 11, 2025
Merged

Add support for deployment.environment.name#329
mxiamxia merged 1 commit intoamazon-contributing:aws-ocb-devfrom
blairhyy-amazon:aws-ocb-dev

Conversation

@blairhyy-amazon
Copy link

@blairhyy-amazon blairhyy-amazon commented Jul 9, 2025

Description

ApplicationSignalsProcessor relies on the resource attribute deployment.environment as a customer-provided override for ApplicationSignals Environment. However, deployment.environment has been deprecated and replaced with deployment.environment.name in the upstream.

Replicate the feature in CWA from this PR. Check the PR for more details.

Link to tracking issue

Testing

  1. go test in applicationsignalsprocessor/internal/resolver
  2. E2E testing: metrics -> ADOT SDK -> OTLP receiver -> app signal processor -> emf exporter -> any log group
  • Only deployment.environment is defined -> Environment is set
  • Only deployment.environment.name is defined -> Environment is set
  • deployment.environment=deprecate,deployment.environment.name=test-processor -> Environment=deprecate or Environment=test-processor
  • deployment.environment.name=test-processor,deployment.environment=deprecate -> Environment=deprecate or Environment=test-processor
  • No environment information -> Environment=ec2:default

Documentation

Copy link

@thpierce thpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes align with aws/amazon-cloudwatch-agent#1722, will approve once testing done.

@blairhyy-amazon blairhyy-amazon marked this pull request as ready for review July 11, 2025 16:59
@mxiamxia mxiamxia merged commit 648599a into amazon-contributing:aws-ocb-dev Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants