Add support for deployment.environment.name#329
Merged
mxiamxia merged 1 commit intoamazon-contributing:aws-ocb-devfrom Jul 11, 2025
Merged
Add support for deployment.environment.name#329mxiamxia merged 1 commit intoamazon-contributing:aws-ocb-devfrom
mxiamxia merged 1 commit intoamazon-contributing:aws-ocb-devfrom
Conversation
c02544c to
6572d34
Compare
6572d34 to
b59ad15
Compare
thpierce
reviewed
Jul 9, 2025
thpierce
left a comment
There was a problem hiding this comment.
Changes align with aws/amazon-cloudwatch-agent#1722, will approve once testing done.
thpierce
approved these changes
Jul 11, 2025
mxiamxia
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ApplicationSignalsProcessor relies on the resource attribute
deployment.environmentas a customer-provided override for ApplicationSignalsEnvironment. However,deployment.environmenthas been deprecated and replaced withdeployment.environment.namein the upstream.Replicate the feature in CWA from this PR. Check the PR for more details.
Link to tracking issue
Testing
go testin applicationsignalsprocessor/internal/resolverdeployment.environmentis defined ->Environmentis setdeployment.environment.nameis defined ->Environmentis setdeployment.environment=deprecate,deployment.environment.name=test-processor->Environment=deprecateorEnvironment=test-processordeployment.environment.name=test-processor,deployment.environment=deprecate->Environment=deprecateorEnvironment=test-processorEnvironment=ec2:defaultDocumentation