Add Nvme scrape configs for LIS CSI#382
Conversation
agarakan
force-pushed
the
nvme_scrape_configs
branch
from
ca7a824 to
100b49d
Compare
agarakan
force-pushed
the
nvme_scrape_configs
branch
from
1d8854f to
3d9b2e3
Compare
| decoConsumer := decoratorconsumer.DecorateConsumer{ | ||
| ContainerOrchestrator: ci.EKS, | ||
| NextConsumer: acir.nextConsumer, | ||
| MetricType: ci.TypeNodeNVME, |
There was a problem hiding this comment.
I thought we created a new node type for these EMF logs?
There was a problem hiding this comment.
I see this gets overwritten with a Type label set in the processor - aws/amazon-cloudwatch-agent#1943.
But its unclear why these have to be out of sync. Not necessarily an issue with your changes, since i see its the same for the EBS as well - but something we should just fix for both in a follow up.
|
nit: Mind updating the desc with results from your testing? Its useful to show sample metrics in CW and a sample EMF log so we can validate the fields in there. Edit: I can see a sample EMF log here - aws/amazon-cloudwatch-agent#1943. But would be good to add that and a CW screenshot to both PRs so ppl can find them in the context of the respective PRs. Or atleast link the PRs in the desc. |
5 participants
Description
Adding Scrape Configs to collect NVMe metrics from Local Instance Store (LIS) CSI
Testing
Unit tests updated
Validated by building into CWA and running the agent on a test cluster