Skip to content

Updates 'org.jetbrains.intellij' version to fix the task failure of downloadZipSigner. #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linlin-s merged 2 commits into from
Jul 19, 2023
Merged

Updates 'org.jetbrains.intellij' version to fix the task failure of downloadZipSigner. #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6207162
Updates 'org.jetbrains.intellij' version to fix the task failure of d…
linlin-s Jul 19, 2023
c662a02
Adds notes on plugin version choice.
linlin-s Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ buildscript {

plugins {
kotlin("jvm")
id("org.jetbrains.intellij") version "1.12.0"
// TODO: The version need to be updated to the latest version 1.15.0.
// There will be configuration issues need to be solved after upgrading to the latest version 1.15.0.
id("org.jetbrains.intellij") version "1.13.2"
Copy link
Contributor

@jobarr-amzn jobarr-amzn Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why pick this specific version instead of 1.14.0 or 1.15.0?

Copy link
Contributor Author

@linlin-s linlin-s Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now we can use the version 1.13.2 to unblock the current release. There will be more configuration issues to solve than expected when changing the version to 1.14.0 or 1.15.0. I added a TODO in the next commit.

}

repositories {
Expand Down Expand Up @@ -107,18 +109,18 @@ tasks {
compileKotlin {
kotlinOptions {
apiVersion = descriptor.kotlin.apiVersion
jvmTarget = "11"
jvmTarget = "17"
}
}

withType<KotlinCompile> {
kotlinOptions {
jvmTarget = "11"
jvmTarget = "17"
}
}

withType<JavaCompile> {
options.release.set(11)
options.release.set(17)
}

buildPlugin {
Expand Down
2 changes: 1 addition & 1 deletion buildSrc/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ repositories {
}

dependencies {
api(kotlin("gradle-plugin", version = "1.9.0-Beta"))
api(kotlin("gradle-plugin", version = "1.9.0"))
}