Merged
Conversation
linlin-s
approved these changes
Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Follow up for #73
Description of changes:
Publishing a beta release failed because it tried to publish version
2.0. I looked into the git history, and I don't know why thepackageVersiongradle property even exists. It wasn't being used for anything prior as far as I can tell, and I guess in the migration to using the new intellijPlatform gradle plugin, it did end up getting used inadvertently.I've also lowered the plugin version because the most recent release is
2.6.1, so there's no reason to go to2.8.1for the next release.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.