Conversation
this sounds like a loss, but the thing wouldn't have worked for custom behaviors either way, as callback for behaviors would have to be implemented by overriding methods in block class, and introducing yet another block class will only bring trouble with inheritance
fix(datagen): safevarargs feat: block entity model
Member
|
what is YAAR |
Member
Author
|
yet another ait rewrite |
Member
Author
|
xd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR add?
Allows to compose blocks instead of fucking around with inheritance.
BlockEntityModelclass that just extendsSinglePartEntityModeland silences the generic warning.FluidContainerregistry (ported from stargate).@SafeVarargson model provider and block tag provider.StructurePlaceableBlockEntityapi (ported from stargate & ait).aitstargate).