Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR brings over and updates various CI workflows from the AIT project, and adds a Python script to automate changelog entries.
- Introduces
scripts/update_changelog.pyand itsrequestsdependency - Adds/updates multiple GitHub Actions workflows for bug form updates, changelog automation, labeling, and publishing
- Removes several deprecated workflows and updates templates and funding configuration
Reviewed Changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/update_changelog.py | New Python script to append PR entries to CHANGELOG |
| scripts/requirements.txt | Adds requests~=2.32.3 dependency |
| .github/workflows/update-bug-form.yml | Workflow to append mod version to bug report form |
| .github/workflows/publish_release_github.yml | Removed old “Publish Release on GitHub” workflow |
| .github/workflows/publish_beta_github.yml | Removed old “Publish Beta on GitHub” workflow |
| .github/workflows/publish_beta_discord.yml | Removed old Discord beta-build workflow |
| .github/workflows/publish.yml | Consolidated publish workflow for GitHub/Modrinth/CurseForge |
| .github/workflows/publish-devbuilds.yml | Updated dev-builds workflow to “donator builds” |
| .github/workflows/pr-labeler.yml | Adds PR labeler workflow |
| .github/workflows/clear_changelog.yml | Workflow to clear CHANGELOG after release merges |
| .github/workflows/append_changelog.yml | Workflow to append merged PRs to CHANGELOG.md |
| .github/workflows/all-labeler-untriaged.yml | Workflow to auto-label untriaged issues/PRs |
| .github/labeler.yml | File-change-based PR label mappings |
| .github/PULL_REQUEST_TEMPLATE.md | Updated pull request template |
| .github/ISSUE_TEMPLATE/2-feature-request.yaml | New feature-request issue template |
| .github/ISSUE_TEMPLATE/1-bug-report.yaml | New bug-report issue template |
| .github/FUNDING.yml | Updates Patreon and Ko-fi entries |
Comments suppressed due to low confidence (6)
.github/workflows/update-bug-form.yml:29
- The echoed filename
1_bug_report.yamldoes not match the actual filename1-bug-report.yaml; update the message for accuracy.
echo "Version $MOD_VERSION already exists in 1_bug_report.yaml"
.github/workflows/all-labeler-untriaged.yml:14
- GitHub Actions expressions do not support a
joinfunction; this condition will fail. Use a supported expression to test for absent labels.
if: join(github.event.issue.labels) == ''
.github/ISSUE_TEMPLATE/1-bug-report.yaml:41
- The default value
0isn’t one of the listed version options; this may confuse users. Set a valid default or remove it.
default: 0
.github/ISSUE_TEMPLATE/2-feature-request.yaml:27
- The
checkboxesinput is missing anidfield, which is required for form processing. Add anid:to this block.
- type: checkboxes
.github/workflows/publish-devbuilds.yml:63
- [nitpick] There is a large commented-out alternative Gradle setup block that may clutter the workflow. Consider removing or moving to documentation.
# NOTE: The Gradle Wrapper is the default and recommended way to run Gradle (https://docs.gradle.org/current/userguide/gradle_wrapper.html).
.github/PULL_REQUEST_TEMPLATE.md:16
- [nitpick] The guidelines link points to
amblelabs.github.io/ait-wiki; verify that this is the correct and accessible documentation location for this repo.
- [ ] I have read and am following the [Pull Request and Changelog Guidelines](https://amblelabs.github.io/ait-wiki/guidelines).
Comment on lines
+67
to
+68
| suffix = f" by {authors_md}" if authors_md else "" | ||
| lines.append(f"- {clean} |{suffix} ([#{num}]({link}))") |
There was a problem hiding this comment.
[nitpick] The formatting always adds a | even when there are no authors; consider only including the pipe and suffix when authors_md is non-empty to avoid stray separators.
Suggested change
| suffix = f" by {authors_md}" if authors_md else "" | |
| lines.append(f"- {clean} |{suffix} ([#{num}]({link}))") | |
| suffix = f" | by {authors_md}" if authors_md else "" | |
| lines.append(f"- {clean}{suffix} ([#{num}]({link}))") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.