-
Notifications
You must be signed in to change notification settings - Fork 23
feat: implement status update breaks #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements status update breaks functionality, allowing users to define periods where status update streaks should not be affected by missed updates. The implementation includes database schema changes, model definitions, and query modifications to exclude break periods from streak calculations.
- Adds database table and model structures for status breaks
- Modifies consecutive miss calculation to exclude dates during break periods
- Provides GraphQL mutation for creating status breaks
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/models/status_update.rs | Defines StatusBreakRecord and CreateStatusBreakInput structs |
| src/graphql/queries/member_queries.rs | Updates consecutive miss query to filter out break periods |
| src/graphql/mutations/status_mutations.rs | Adds create_status_break mutation |
| migrations/20251013082516_implement_status_breaks.sql | Creates statusbreaks table |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bc9b13a to
eeeb97e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
eeeb97e to
6b4d2d6
Compare
9977804 to
9231412
Compare
ivinjabraham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds a new table to track when status update streak tracking should be paused for a batch.
Integrated the above with the miss-streak calculation and added a new attribute
on_breakto theon_datestatus update query.