Skip to content

Add ability to read, and set the active state of streams on groups#29

Merged
amimof merged 14 commits intoamimof:masterfrom
steelphase-forks:stream-stuff
Nov 11, 2020
Merged

Add ability to read, and set the active state of streams on groups#29
amimof merged 14 commits intoamimof:masterfrom
steelphase-forks:stream-stuff

Conversation

@SteelPhase
Copy link
Contributor

@SteelPhase SteelPhase commented Oct 23, 2020

This is exposing the RESTful portion of the Entertainment API

@codecov-io
Copy link

codecov-io commented Oct 23, 2020

Codecov Report

Merging #29 into master will decrease coverage by 0.50%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   67.28%   66.78%   -0.51%     
==========================================
  Files           5        5              
  Lines        1131     1165      +34     
==========================================
+ Hits          761      778      +17     
- Misses        202      214      +12     
- Partials      168      173       +5     
Impacted Files Coverage Δ
group.go 86.40% <50.00%> (-13.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b16d16...648a98c. Read the comment docs.

@amimof
Copy link
Owner

amimof commented Oct 26, 2020

@SteelPhase Thanks for the contribution. I was thinking. Perhaps it’s better to name the functions EnableStreaming() and DisableStreaming() for readability. What do you think?

@SteelPhase
Copy link
Contributor Author

That's a good Name. I was undecided on what to call it and just picked something. I'll try it out.

@SteelPhase
Copy link
Contributor Author

Sorry for the delay. I adjust the naming, and tested further. Found a few bugs with how nil booleans were handled in the DisableStream function. Verified it's all working as it should.

Copy link
Owner

@amimof amimof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Have a look at my comments

@SteelPhase
Copy link
Contributor Author

Going to need a bit of time to look at the tests, but i'll verify what I can soon

@SteelPhase
Copy link
Contributor Author

I added significantly more testing around the entertainment api components

@SteelPhase
Copy link
Contributor Author

Got sick of fighting with the unit tests differences between 1.13 and 1.14, I split them out. I'm waiting for the travis-ci job to complete.

@SteelPhase
Copy link
Contributor Author

I think this is ready for review again

@amimof
Copy link
Owner

amimof commented Nov 9, 2020

@SteelPhase You might have already tried it but perhaps you could use the assert? For example:

_, err := b.getAPIPath("/")
assert.NotNil(t, err)

@SteelPhase
Copy link
Contributor Author

Switched it over to use assert.NotNil

Copy link
Owner

@amimof amimof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Two minor typos. I’ll merge once fixed

@SteelPhase
Copy link
Contributor Author

Should be fixed. got distracted with GopherCon stuff

@amimof amimof merged commit 08ce5c3 into amimof:master Nov 11, 2020
@SteelPhase SteelPhase deleted the stream-stuff branch November 11, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants