Add ability to read, and set the active state of streams on groups#29
Add ability to read, and set the active state of streams on groups#29amimof merged 14 commits intoamimof:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
- Coverage 67.28% 66.78% -0.51%
==========================================
Files 5 5
Lines 1131 1165 +34
==========================================
+ Hits 761 778 +17
- Misses 202 214 +12
- Partials 168 173 +5
Continue to review full report at Codecov.
|
|
@SteelPhase Thanks for the contribution. I was thinking. Perhaps it’s better to name the functions EnableStreaming() and DisableStreaming() for readability. What do you think? |
|
That's a good Name. I was undecided on what to call it and just picked something. I'll try it out. |
|
Sorry for the delay. I adjust the naming, and tested further. Found a few bugs with how nil booleans were handled in the DisableStream function. Verified it's all working as it should. |
amimof
left a comment
There was a problem hiding this comment.
Nicely done. Have a look at my comments
|
Going to need a bit of time to look at the tests, but i'll verify what I can soon |
|
I added significantly more testing around the entertainment api components |
|
Got sick of fighting with the unit tests differences between 1.13 and 1.14, I split them out. I'm waiting for the travis-ci job to complete. |
|
I think this is ready for review again |
|
@SteelPhase You might have already tried it but perhaps you could use the assert? For example: |
|
Switched it over to use assert.NotNil |
amimof
left a comment
There was a problem hiding this comment.
Nice work! Two minor typos. I’ll merge once fixed
|
Should be fixed. got distracted with GopherCon stuff |
This is exposing the RESTful portion of the Entertainment API