Fix deprecation error for null in strtolower() call#836
Open
zambodaniel wants to merge 1 commit intoandersao:masterfrom
Open
Fix deprecation error for null in strtolower() call#836zambodaniel wants to merge 1 commit intoandersao:masterfrom
zambodaniel wants to merge 1 commit intoandersao:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a PHP 8.1+ deprecation warning in the RequestCriteria class by adding null safety when calling strtolower() on the $searchJoin variable. In PHP 8.1 and later, passing null to string functions like strtolower() triggers deprecation warnings that will become fatal errors in PHP 9.0.
Changes:
- Added null coalescing operator (
??) to provide an empty string default when$searchJoinis null before callingstrtolower()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor adjustment to the
applymethod inRequestCriteria.phpto improve robustness when handling the$searchJoinvariable.??) when callingstrtoloweron$searchJoin, preventing potential errors if$searchJoinis null. (src/Prettus/Repository/Criteria/RequestCriteria.php)