Use TranslationUnitDecl handler instead of the previous matchers.#615
Merged
andreasfertig merged 2 commits intomainfrom Mar 11, 2024
Merged
Use TranslationUnitDecl handler instead of the previous matchers.#615andreasfertig merged 2 commits intomainfrom
TranslationUnitDecl handler instead of the previous matchers.#615andreasfertig merged 2 commits intomainfrom
Conversation
This change introduces a `TranslationUnit` handler, replacing the previous matchers. The advantage is that _all_ statements are processed, not only the ones where an exact match exists. The new approach fixes #376, #500, and #588. There is one disadvantage: for primary templates, some code is not reproduced as written. This causes one compile issue.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
==========================================
+ Coverage 97.88% 98.03% +0.14%
==========================================
Files 27 20 -7
Lines 5067 4880 -187
==========================================
- Hits 4960 4784 -176
+ Misses 107 96 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a
TranslationUnithandler, replacing the previous matchers. The advantage is that all statements are processed, not only the ones where an exact match exists.The new approach fixes #376, #500, and #588.
There is one disadvantage: for primary templates, some code is not reproduced as written. This causes one compile issue.