Skip to content

Conversation

@thatfiredev
Copy link
Contributor

The firebase-config-ktx library has been deprecated as all functionality can be found in the firebase-config library.

I have no idea why it was in the build config in the first place, as it seems like it wasn't being used. (we already depend on firebase-config)

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @thatfiredev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on cleaning up the project's build configuration by removing an unused and deprecated Firebase library. Specifically, it removes the firebase-config-ktx dependency, as its functionality is already provided by the existing firebase-config library. This change helps to reduce build complexity and ensure that only necessary dependencies are included in the project.

Highlights

  • Dependency Removal: The firebase-config-ktx dependency, which was deprecated and unused, has been removed from the core/network module's build configuration.
  • Build Configuration Cleanup: The corresponding version and library definition for firebase-config-ktx have been removed from gradle/libs.versions.toml, streamlining the project's dependency management.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the deprecated firebase-config-ktx dependency. Since the functionality of this KTX library is now included in the main firebase-config library (which is already a dependency in the project), this change is a good housekeeping measure that cleans up the project's dependencies. The modifications in core/network/build.gradle.kts and gradle/libs.versions.toml are accurate and complete.

@riggaroo riggaroo merged commit 78744e2 into android:main Aug 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants