-
Notifications
You must be signed in to change notification settings - Fork 259
Updates build files for Wear OS #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @garanj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces support for building Wear OS application bundles (AABs) within the existing build system. It extends the current build scripts to generate AABs for Wear OS alongside the standard Android AABs, ensuring both platforms are covered in the release process.
Highlights
- Wear OS Build Integration: The build scripts (build.sh and build_presubmit.sh) have been updated to include commands for building Wear OS production release bundles.
- Wear OS Artifact Collection: Logic has been added to collect and prepare Wear OS AABs and their associated SPDX SBOMs for artifact storage.
- Version Bumps: The application version code and name have been incremented in gradle/libs.versions.toml.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the build scripts to add support for building Wear OS AABs alongside the existing Android AABs. The changes correctly add the Gradle tasks for the wear module. However, I've found a critical issue where an undefined variable is used when copying the Wear OS artifact, which will cause the build to fail. Additionally, there is significant code duplication in both build.sh and build_presubmit.sh for artifact collection, which should be refactored to improve maintainability. I've also noted a potentially unintentional removal of a Gradle task exclusion in the presubmit script.
First draft at trying to get the build scripts to handle Wear OS
Should produce Wear OS AABs as well as the existing Android AABs. 🤞