Skip to content

Conversation

@riggaroo
Copy link
Collaborator

@riggaroo riggaroo commented Sep 11, 2025

Reverts #124 and changes it to use a separate release_wear.cfg

@riggaroo riggaroo requested a review from tiwiz as a code owner September 11, 2025 17:43
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @riggaroo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily reverts a previous change (#124) by consolidating the Kokoro build configurations for mobile and Wear OS application bundle (AAB) artifacts. It streamlines the artifact definition process by replacing multiple specific artifact definitions with a single, more generalized configuration. Additionally, this change introduces the automated collection of .intoto.jsonl files as part of the build artifacts and rolls back the application's version numbers.

Highlights

  • Kokoro Configuration Consolidation: The Kokoro build configurations (continuous.cfg, presubmit.cfg, and release.cfg) have been updated to consolidate artifact definitions. Previously separate artifact definitions for phone and Wear OS AABs are now replaced by a single action.define_artifacts block, streamlining the artifact collection process for both application bundles and associated metadata.
  • In-Toto Metadata Collection: Build scripts (build.sh and build_presubmit.sh) now include logic to automatically find and copy .intoto.jsonl files, which are likely related to supply chain security metadata, into the designated build artifact directory.
  • Application Version Reversion: The gradle/libs.versions.toml file has been modified to revert the appVersionCode from 7 to 6 and appVersionName from 1.1.5 to 1.1.4, indicating a rollback of a previous version update.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Kokoro build configurations to simplify artifact collection and adds logic to the build scripts to handle .intoto.jsonl files.

My review has identified a couple of areas for improvement:

  • Build Script Inefficiency: The new logic in build.sh and build_presubmit.sh to copy .intoto.jsonl files runs the find command twice, which is inefficient and contradicts the accompanying comment. I've suggested a more efficient and robust approach using a bash array.
  • Artifact Storage Path: The changes in the Kokoro .cfg files remove the explicit GCS paths that previously separated mobile and Wear OS artifacts. This could lead to both types of artifacts being stored in the same location, which might be unintended. I've raised this as a high-severity concern.

The version downgrade in gradle/libs.versions.toml appears to be part of the intended revert mentioned in the PR description, so I have not commented on it. Please review the suggested changes to ensure the build process is both correct and efficient.

@riggaroo riggaroo requested a review from garanj September 12, 2025 08:35
@riggaroo riggaroo merged commit b782895 into main Sep 12, 2025
4 checks passed
@riggaroo riggaroo deleted the revert-124-wear-os-release branch September 12, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants