Fix: Preserve PagerState current page on configuration changes #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osamasayed585
approved these changes
May 23, 2025
riggaroo
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the PagerState in the CreationScreen was resetting to the initial page (index 0) after a configuration change, such as screen rotation. #31
Problem
On screen rotation, PagerState was re-created with the hardcoded initial page index 0, causing the pager to always reset to the first page. This is because the previous state was not preserved across recompositions caused by configuration changes.
Solution
Instead of hardcoding the initial page index to 0, we now use the current selection
(uiState.selectedPromptOption.ordinal)to initialize the pager correctly after recomposition or configuration changes.Recording
Screen_recording_20250524_015546.mp4
Screen_recording_20250524_020620.mp4