Skip to content

Replace unnecessary init block with direct instantiation in HomeViewModel.kt #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riggaroo merged 1 commit into from
Jun 20, 2025
Merged

Replace unnecessary init block with direct instantiation in HomeViewModel.kt #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions feature/home/src/main/java/com/android/developers/androidify/home/HomeViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,27 +16,22 @@
package com.android.developers.androidify.home

import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import com.android.developers.androidify.data.ConfigProvider
import dagger.hilt.android.lifecycle.HiltViewModel
import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.asStateFlow
import kotlinx.coroutines.launch
import javax.inject.Inject

@HiltViewModel
class HomeViewModel @Inject constructor(val configProvider: ConfigProvider) : ViewModel() {
private val _state = MutableStateFlow(HomeState())
class HomeViewModel @Inject constructor(configProvider: ConfigProvider) : ViewModel() {
private val _state = MutableStateFlow(
HomeState(
isAppActive = !configProvider.isAppInactive(),
dancingDroidLink = configProvider.getDancingDroidLink(),
videoLink = configProvider.getPromoVideoLink(),
),
)
val state = _state.asStateFlow()
init {
viewModelScope.launch {
_state.value = _state.value.copy(
isAppActive = !configProvider.isAppInactive(),
dancingDroidLink = configProvider.getDancingDroidLink(),
videoLink = configProvider.getPromoVideoLink(),
)
}
}
}

data class HomeState(
Expand Down