Skip to content

Conversation

@pedrosax
Copy link
Contributor

Update the placeholders for Compose Preview for HomeScreen.kt, both the UI code and assets.

pedrosax added 2 commits July 28, 2025 13:42
Adding Compose Preview Placeholders for HomeScreen.kt so that the compose previews on the file show content while in preview mode in Android Studio
Add placeholder images for HomeScreen.kt that are stills from the original  animated GIF and promo video
@pedrosax pedrosax requested review from riggaroo and tiwiz as code owners July 28, 2025 12:56
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @pedrosax, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the developer experience for HomeScreen.kt by improving its Compose Preview capabilities. It introduces logic to display static placeholder images for dynamic content like dancing bots and video players when the UI is rendered in a preview environment, ensuring that the layout is visually complete and representative without relying on live data or complex player initialization.

Highlights

  • Compose Preview Enhancements: Implemented conditional rendering for the DancingBot and VideoPlayer composables to display static placeholder images when the UI is rendered in Compose Preview mode.
  • Improved Developer Experience: Replaced previously blank or non-functional preview elements with meaningful visual placeholders, making the HomeScreen.kt previews more representative and useful for design-time inspection.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The code changes introduce placeholders for Compose Preview for HomeScreen.kt, which enhances the preview experience by using static images when in inspection mode. This avoids issues with dynamic content loading during design time.

Comment on lines +532 to +539
if (LocalInspectionMode.current) {
Image(
painter = painterResource(id = R.drawable.promo_video_placeholder),
contentDescription = null,
contentScale = ContentScale.Crop,
modifier = modifier,
)
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider extracting the Image composable into a separate function for better readability and maintainability. This would encapsulate the placeholder logic and make the VideoPlayer function cleaner.

@Composable
private fun VideoPlaceholder(modifier: Modifier = Modifier) {
    Image(
        painter = painterResource(id = R.drawable.promo_video_placeholder),
        contentDescription = null,
        contentScale = ContentScale.Crop,
        modifier = modifier,
    )
}

// Usage in VideoPlayer:
if (LocalInspectionMode.current) {
    VideoPlaceholder(modifier = modifier)
    return
}

Comment on lines +460 to +465
if (LocalInspectionMode.current) {
Image(
painter = painterResource(id = R.drawable.dancing_droid_gif_placeholder),
contentDescription = null,
modifier = modifier
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider extracting the Image composable into a separate function for better readability and maintainability. This would encapsulate the placeholder logic and make the DancingBot function cleaner.

@Composable
private fun DancingBotPlaceholder(modifier: Modifier = Modifier) {
    Image(
        painter = painterResource(id = R.drawable.dancing_droid_gif_placeholder),
        contentDescription = null,
        modifier = modifier
    )
}

// Usage in DancingBot:
if (LocalInspectionMode.current) {
    DancingBotPlaceholder(modifier = modifier)
}

pedrosax added 3 commits July 28, 2025 14:59
Moving placeholder images to debug folder so that they don't appear in the release App Bundle.
@pedrosax pedrosax marked this pull request as draft July 28, 2025 14:29
@pedrosax pedrosax marked this pull request as ready for review July 28, 2025 14:45
@riggaroo riggaroo merged commit 4aa8f1f into android:main Jul 29, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants