Offscreen bitmap renderer:

[riggaroo]

Revert to not re-using the surface due to crashes with android.view.WindowManager$BadTokenException: Unable to add window android.view.ViewRootImpl$W@8189b37 -- permission denied for window type 2030

`

[gemini-code-assist]

Summary of Changes

Hello @riggaroo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've addressed a critical crash related to the offscreen bitmap renderer. The issue stemmed from re-using Surface objects, which led to a WindowManager$BadTokenException. To fix this, I've reverted the approach to ensure that Surface and VirtualDisplay resources are now created and released for each rendering operation. This change simplifies the renderer's lifecycle by removing explicit initialize() and dispose() methods, ensuring robust resource handling and preventing the permission-related crash.

Highlights

• Crash Fix: The primary goal of this pull request is to resolve a WindowManager$BadTokenException crash that occurred when the offscreen bitmap renderer attempted to re-use Surface objects.
• Resource Management Change: The ComposableBitmapRendererImpl now creates and disposes of SurfaceTexture, Surface, and VirtualDisplay instances on a per-render basis within the useVirtualDisplay function. This ensures proper resource management and prevents permission-related issues.
• API Simplification: The initialize() and dispose() methods have been removed from the ComposableBitmapRenderer interface and its implementation, simplifying the renderer's lifecycle management as resources are now handled internally per operation.
• ViewModel Cleanup: The CustomizeExportViewModel no longer explicitly calls dispose() on the renderer in its onCleared() method, aligning with the renderer's new internal resource management strategy.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request reverts the ComposableBitmapRenderer to not re-use a Surface, which should resolve the WindowManager$BadTokenException crash. This is a good change.

I've found a critical issue in the new implementation of useVirtualDisplay that could lead to a NullPointerException and resource leaks. I've provided a suggestion to make it more robust. I also found a couple of unused imports that should be removed.

Additionally, please note that the changes to the ComposableBitmapRenderer interface (removing initialize and dispose) will require updates to its fake implementation in FakeComposableBitmapRenderer.kt to avoid compilation errors.

[gemini-code-assist]

This WindowManager import is unused and can be removed to improve code clarity.