This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(tutorial): bring up-to-date with latest angular-phonecat/angular-seed
#16753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
force-pushed
the
docs-tutorial-upgrade-to-1.7
branch
from
20914b6 to
cb6aff6
Compare
docs/content/tutorial/index.ngdoc
Outdated
| If you want to run the preconfigured local web server and the test tools then you will also need | ||
| [Node.js v4+][node]. | ||
| In order to install dependencies (such as the test tools and AngularJS itself) and run the | ||
| preconfigured local web server, you will also need [Node.js v4+][node]. |
Contributor
There was a problem hiding this comment.
Did you check it works with node 4?
Member
Author
There was a problem hiding this comment.
Good question 🤔
I did now and it doesn't work (because Protractor is not compatible with <6) 😞
But it does work with v6 (see link above), which I think it is more than reasonable 😃
I will change it to 6+. Good catch 👍
Member
Author
There was a problem hiding this comment.
Also, updated angular/angular-phonecat#430 to test against v6 as well.
docs/content/tutorial/index.ngdoc
Outdated
|
|
||
| ### Updating dependencies | ||
|
|
||
| In order to avoid surprizes, all dependencies listed in `package.json` are pinned to specific |
| module('phonecatApp'). | ||
| config(['$locationProvider', '$routeProvider', | ||
| function config($locationProvider, $routeProvider) { | ||
| $locationProvider.hashPrefix('!'); |
petebacondarwin
approved these changes
Nov 2, 2018
Contributor
petebacondarwin
left a comment
petebacondarwin
left a comment
There was a problem hiding this comment.
A few minor comments. Good stuff!
Protractor's `browser.getLocationAbsUrl()` has been deprecated and `browser.getCurrentUrl()` is the recommended alternative. Related: angular/angular-phonecat#430
Since Protractor requires specific WebDriver versions and these are only compatible with specific browser version ranges, it is often necessary to upgrade Protractor just so that it picks up a more recent WebDriver version. Related: angular#16739
gkalpak
force-pushed
the
docs-tutorial-upgrade-to-1.7
branch
from
cb6aff6 to
98129d7
Compare
Member
Author
|
@petebacondarwin, updated. PTAL |
gkalpak
force-pushed
the
docs-tutorial-upgrade-to-1.7
branch
from
20225ec to
98129d7
Compare
petebacondarwin
approved these changes
Nov 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following changes:
https.bowertonpmand upgrade AngularJS to 1.7.x.getLocationAbsUrl()withgetCurrentUrl().Related PRs: