This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Closed
Conversation
Contributor
|
Looks good. Only caveat is that we like to have tests represent the situation that this is fixing, rather than the closure lib code that was triggering the error. That way the tests are more mainainable. In order to expedite landing the fix, I fixed your tests and created a new PR - #834. I tried to preserve your ownership of the commit. |
Contributor
Author
|
@rkirov thanks! 👍 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #822,
goog.module.ModuleLoader.EvaluateCodeEventand some classes are emitted twice throwingTS2300: Duplicate identifier.Because
goog.module.ModuleLoader.EvaluateCodeEventis emitted as an inner class of not onlygoog.module.ModuleLoaderbut alsogoog.module.