build: fix travis required tests not running#8437
Merged
jelbourn merged 2 commits intoangular:masterfrom Nov 18, 2017
Merged
Conversation
googlebot
added
the
cla: yes
* Fixes that the `travis_required` CI mode isn't running. This mode is important for Firefox and Chrome testing.
devversion
force-pushed
the
build/fix-travis-required-mode
branch
from
5315baa to
7b87e06
Compare
Member
Author
|
@jelbourn Fixed the test failure in Firefox 57. Everything is green now! |
jelbourn
approved these changes
Nov 14, 2017
Contributor
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM, add merge-ready when ready
| it('should be treated as empty if type is date on Firefox and IE', | ||
| inject([Platform], (platform: Platform) => { | ||
| if (platform.TRIDENT || platform.FIREFOX || (platform.SAFARI && !platform.IOS)) { | ||
| if (platform.TRIDENT || (platform.SAFARI && !platform.IOS)) { |
Contributor
There was a problem hiding this comment.
Update the comment above?
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
travis_requiredCI mode isn't running. This mode is important for Firefox and Chrome testing.