Skip to content

fix: remove IGNORED_MESSAGE_TAGS filter so transactional contacts reach refined table #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malek10xdev merged 2 commits into from
Mar 26, 2026
Merged

fix: remove IGNORED_MESSAGE_TAGS filter so transactional contacts reach refined table #2746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
739389d
fix: remove IGNORED_MESSAGE_TAGS filter in EmailMessage extractContacts
malek10xdev Mar 26, 2026
3aab105
update unit tests
malek10xdev Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions backend/src/services/extractors/engines/EmailMessage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,12 +333,14 @@ export default class EmailMessage {
field: validContact.sourceField
});

// Eliminate unwanted contacts associated with tags listed in IGNORED_MESSAGE_TAGS
if (
tags.some((t) => EmailMessage.IGNORED_MESSAGE_TAGS.includes(t.name))
) {
return;
}
// TODO: [BUG] Re-enable once refine process properly handles transactional tag
// Previously this filtered out contacts from transactional emails, but it caused
// transactional-tagged contacts to be missing from the refined table.
// if (
// tags.some((t) => EmailMessage.IGNORED_MESSAGE_TAGS.includes(t.name))
// ) {
// return;
// }

if (tags.some((t) => t.reachable === REACHABILITY.DIRECT_PERSON)) {
if (
Expand Down
29 changes: 29 additions & 0 deletions backend/test/unit/emailMessage.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,35 @@ describe('Email Message', () => {
reachable: REACHABILITY.DIRECT_PERSON
}
]
},
{
person: {
name: 'test',
email: 'invalid@leadminer.io',
identifiers: ['invalid'],
source: 'miningSource@leadminer.io'
},
pointOfContact: {
name: 'test',
to: false,
cc: false,
bcc: false,
body: false,
from: true,
replyTo: false
},
tags: [
{
name: 'transactional',
source: 'refined#message_header',
reachable: 3
},
{
name: 'no-reply',
source: 'refined#email_address',
reachable: 3
}
]
}
];
const contacts = await message.getContacts();
Expand Down
Loading