Log cleanup threshold & Bus subscription memory leak

[NotUnHackable]

Description

Log cleanup threshold (src/util/log.ts): Fixed inconsistent threshold check - was checking files.length <= 5 but keeping last 10 files with slice. Changed to files.length <= 10 to match the slice logic.
Bus subscription memory leak (src/bus/index.ts): When all subscribers for an event type unsubscribed, the empty array remained in the subscriptions Map. Added cleanup to delete the key when the array becomes empty.

Plugins

No response

OpenCode version

No response

Steps to reproduce

No response

Screenshot and/or share link

No response

Operating System

No response

Terminal

No response

[github-actions]

This issue doesn't fully meet our contributing guidelines.

What needs to be fixed:

• This appears to describe fixes/patches already made rather than reporting bugs with steps to reproduce. A bug report should describe the problem you observed, not the solution.
• Required fields are left as _No response_: OpenCode version, Steps to reproduce, Operating System, and Terminal. Please fill in at least the version and reproduction steps so maintainers can verify the reported behavior.

Please edit this issue to address the above within 2 hours, or it will be automatically closed.

---

This issue might be a duplicate of existing issues. Please check:

• Log cleanup deletes newest log files instead of oldest (path-scurry reverse ordering) #14731: Covers the exact same log cleanup threshold bug in src/util/log.ts (the files.length <= 5 vs slice(0, -10) inconsistency) with detailed analysis and reproduction steps.
• Memory leak: Uncleaned timeouts, intervals, and subscriptions #9156: Covers Bus.subscribe cleanup / memory leaks from uncleaned subscriptions in similar areas of the codebase.

If you believe this was flagged incorrectly, please let a maintainer know.

[github-actions]

This issue has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new issue that follows our issue templates.

[jnorthrup]

Related: Bus Subscription Memory Leak Pattern

We identified a similar Bus subscription leak pattern in our investigation of WebKit-based runtimes.

Our Finding

In Bun runtime, we found that event subscriptions created but never unsubscribed hold references to closures, preventing GC. This matches your fix in src/bus/index.ts.

Related Leaks Found

We identified 4 JSC GC leaks total:

1. HashTable iterator invalidation during GC
2. Vector assignment during parallel marking
3. SlotVisitor::drainFromShared race condition
4. AST node leaks (for-of destructuring)

Cross-Project Coordination

This appears to be a WebKit JavaScriptCore upstream issue affecting multiple projects:

• anomalyco/opencode (this issue)
• Bun (our runtime)
• Claude Code
• Safari
• React Native

Upstream References

• WPEWebKit OpenAI OSS tool calling #1622: JSC Slotvisitor::drain crash WebPlatformForEmbedded/WPEWebKit#1622
• WebKit #200863: https://bugs.webkit.org/show_bug.cgi?id=200863

Would your Bus subscription fix help other embedders? Consider upstreaming to WebKit.