fix(desktop): Expand font stacks to include macOS Nerd Font default names #10045
Merged
adamdotdevin merged 1 commit intoanomalyco:devfrom Jan 22, 2026
Merged
fix(desktop): Expand font stacks to include macOS Nerd Font default names #10045adamdotdevin merged 1 commit intoanomalyco:devfrom
adamdotdevin merged 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the mono font-family stacks in settings.tsx to include the default font registration names used by Nerd Fonts when installed manually on macOS, to solve NerdFonts not being picked up to be used in the desktops embedded terminal. By listing all the actual font names that macOS assigns to each of the common Nerd Fonts, the app is much more likely to correctly match and display the intended font if a user has any Nerd Font variant installed.
How did you verify your code works?
I confirmed the names of the fonts picked up by MacOS when manually installing each font then tested these font stacks locally on my macOS machine with several Nerd Fonts installed and confirmed that they appear correctly in the embedded terminal