Skip to content

fix: normalize directory paths for session list queries on Windows#17067

Open
HRronaldo wants to merge 25 commits intoanomalyco:devfrom
HRronaldo:fix/session-list-windows-v2
Open

fix: normalize directory paths for session list queries on Windows#17067
HRronaldo wants to merge 25 commits intoanomalyco:devfrom
HRronaldo:fix/session-list-windows-v2

Conversation

@HRronaldo
Copy link
Copy Markdown

@HRronaldo HRronaldo commented Mar 11, 2026

Issue for this PR

Closes #16878
Closes #16562

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

On Windows, session visibility breaks due to path representation differences (e.g., B: vs b:, / vs ). When users create sessions from different path formats (terminal, different tools, etc.), the stored directory path may differ from the path used when querying sessions later. This causes old sessions to not appear in the session list.
The fix adds a normalizeDirectory() function that normalizes:

  • Backslashes → forward slashes
  • Drive letters → uppercase (for case-insensitive comparison on Windows)
    Applied to:
  • Session.toRow() — normalizes directory when storing new sessions
  • Session.list() — normalizes directory when querying sessions for a project
  • Session.listGlobal() — normalizes directory when querying all sessions
    This ensures consistent path comparison for session listing regardless of how the path was originally entered.

How did you verify your code works?

  • The fix follows the same pattern already merged in commit da1ee12 (which was applied after v1.2.20)
  • The logic is straightforward string normalization with platform-specific handling
  • Code follows existing patterns in the codebase

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

opencode-agent bot and others added 14 commits February 11, 2026 15:20
✨ 功能改进:
- 🔍 智能检测同步提交并跳过生成
- 🎛️ 支持手动触发(workflow_dispatch)
- 🏃 使用标准ubuntu-latest runner
- 🔄 添加GitHub App不可用时的备用认证
- 📝 提供清晰的状态反馈和错误处理

🔧 修复问题:
- 解决Blacksmith runner在fork中的权限问题
- 避免同步操作触发无意义的生成任务
- 提供友好的错误信息和操作指导
On Windows, session visibility can break due to path representation differences
(B: vs b:, / vs \). This fix normalizes directory paths in Session.list
and Session.listGlobal queries using Filesystem.resolve to ensure consistent
path comparison.

Fixes: anomalyco#14570
@HRronaldo HRronaldo requested a review from adamdotdevin as a code owner March 13, 2026 15:53
tcflying pushed a commit to tcflying/opencode that referenced this pull request Mar 29, 2026
Fixes Windows session list display issues where sessions become invisible due to path separator inconsistencies.

Changes:
- Add normalizePathSeparators() function to filesystem utilities
- Normalize paths in session.createNext() when storing sessions
- Normalize paths in Session.list() when querying by directory
- Normalize paths in Session.listGlobal() when querying by directory
- Normalize paths in Project.discover() when updating session project IDs

This resolves GitHub Issues anomalyco#16744 and anomalyco#18029 where sessions created with backslash paths would not be visible when querying with forward slash paths, or vice versa.

Related to PR anomalyco#17067 by HRronaldo

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Old sessions cannot be loaded OpenCode web sidebar sessions have disappeared

1 participant