fix(app): fix session list sorting by id rather than updated time#17848
Open
Rohansguliani wants to merge 1 commit intoanomalyco:devfrom
Open
fix(app): fix session list sorting by id rather than updated time#17848Rohansguliani wants to merge 1 commit intoanomalyco:devfrom
Rohansguliani wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate Found:
Why it's related: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17474
Type of change
What does this PR do?
Fixes a bug where the session list is sorted by ID rather than updated time, leading to older sessions randomly appearing at the top until "Load More" is clicked.
The root cause was
trimSessionsin the local cache sorting sessions ascending (oldest-first) instead of newest-first before slicing. This PR updatestrimSessionsto properly keep the most recent sessions. It also fixes the 60-second fallback sorting logic inhelpers.tsso active sessions appear at the top chronologically.How did you verify your code works?
Tested the changes locally by building the frontend and running the backend server via Tailscale. Verified that new and updated sessions properly surface to the top of the sidebar. Also fixed and ran the unit tests in
event-reducer.test.tsto assertsession.createdbehaves as expected with trimming.Screenshots / recordings
@Rohansguliani - Please attach a screen recording to this PR to satisfy the UI changes compliance rule!
Checklist