Closed
Conversation
Constrain BusEvent.define to ZodObject instead of ZodType so TS knows
event properties are always a record. Type GlobalBus payload as
{ type: string; properties: Record<string, unknown> } instead of any.
Refactor watcher test to use Bus.subscribe instead of raw GlobalBus
listener, removing hand-rolled event types and unnecessary casts.
…ce pattern Replace the legacy Instance.state() lazy-init pattern with the standard Effect service pattern (Interface, Service class, Layer, promise facades). Register Plugin.Service in InstanceServices and add its layer to the instance lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pluginfrom legacyInstance.state()pattern to Effect service pattern (Interface, Service class, Layer, promise facades)Plugin.ServiceinInstanceServicesand addPlugin.layerto the instance lookup ininstances.tsTest plan
Instance.stateno longer appears inplugin/index.tsbun run typecheckinpackages/opencode-- no new errors (all existing are pre-existing)bun run testinpackages/opencode-- no new failures