fix: catch exception from fetch call when download Ripgrep binary#21649
Open
XiaoleiJia1005 wants to merge 1 commit intoanomalyco:devfrom
Open
fix: catch exception from fetch call when download Ripgrep binary#21649XiaoleiJia1005 wants to merge 1 commit intoanomalyco:devfrom
XiaoleiJia1005 wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
3 tasks
2bc6612 to
520d50b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #21646
Type of change
What does this PR do?
Adding a proper .catch() handler around the fetch call responsible for downloading the
Ripgrepbinary to capture the network exception.Log the specific target URL that failed to download for debugging purposes.
Throw the existing error RipgrepDownloadFailedError to replace the confusing
Unable to connectmessage.How did you verify your code works?
bun dev
Screenshots / recordings
Only error message changed, no UI change.
Before
After
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.