fix(opencode): delete-to-line-start getting stuck at line boundary#21670
Open
fredsh2k wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): delete-to-line-start getting stuck at line boundary#21670fredsh2k wants to merge 1 commit intoanomalyco:devfrom
fredsh2k wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21663
Type of change
What does this PR do?
deleteToLineStart()in@opentui/coreonly deletes whencursor.col > 0. After clearing a line's content, the cursor is at col 0 and further presses do nothing — it never removes the newline to join with the previous line.This adds an
onKeyDownintercept in the prompt: whendelete-to-line-startfires and the cursor is at col 0 with row > 0, it callsdeleteCharBackward()to remove the newline, joining with the previous line. Repeated presses then continue clearing upward as expected.How did you verify your code works?
bun typecheckinpackages/opencode)Screenshots / recordings
N/A — keyboard behavior fix, no UI change.
Checklist
opencode-cmd-backspace.mov