Skip to content

docs: adding a warning for vulnerability_checks with private repositories#506

Merged
RobPasMue merged 2 commits intomainfrom
doc/vulnerability_checks
Jun 13, 2024
Merged

docs: adding a warning for vulnerability_checks with private repositories#506
RobPasMue merged 2 commits intomainfrom
doc/vulnerability_checks

Conversation

@clatapie
Copy link
Contributor

No description provided.

@clatapie clatapie requested a review from a team as a code owner June 12, 2024 16:02
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@clatapie clatapie changed the title doc: adding a warning for vulnerability_checks with private repositories docs: adding a warning for vulnerability_checks with private repositories Jun 12, 2024
SMoraisAnsys
SMoraisAnsys previously approved these changes Jun 12, 2024
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I left a minor comment on jinja vulnerability to add visibility on the range of affected versions.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is, it is not going to work. Also, the purpose of this PR is not adding the comments - it is for adding the warning. Please do it in a separate PR

@SMoraisAnsys SMoraisAnsys dismissed their stale review June 13, 2024 07:18

Didn't see the PR title which makes my review not accurate...

@clatapie
Copy link
Contributor Author

Thank you very much for all your feedback.
I will revert my changes within the check-vulnerabilities/ignored-safety.txt file and open an issue about it as suggested by @RobPasMue.

@RobPasMue RobPasMue enabled auto-merge (squash) June 13, 2024 15:32
@RobPasMue RobPasMue merged commit ac9f45e into main Jun 13, 2024
@RobPasMue RobPasMue deleted the doc/vulnerability_checks branch June 13, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants