fix: use one input to specify the tag the branch was created from in doc-deploy-changelog#547
Merged
fix: use one input to specify the tag the branch was created from in doc-deploy-changelog#547
Conversation
Contributor
klmcadams
commented
Aug 23, 2024
klmcadams
commented
- Consolidate "update-release-branch" and "update-main-branch" into one input: "release-from-main"
- By default, "release-from-main" is false, meaning the action assumes the tag was created on a release branch
- Included a detailed description for "release-from-main" to clarify the different options
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
the
bug
Andy-Grigg
approved these changes
Aug 23, 2024
Contributor
Andy-Grigg
left a comment
Andy-Grigg
left a comment
There was a problem hiding this comment.
Thank you, this really helps in understanding what the action is doing! A couple of minor comments, but I'm completely happy if you say that it's wordy enough already.
Andy-Grigg
approved these changes
Aug 23, 2024
Contributor
Andy-Grigg
left a comment
Andy-Grigg
left a comment
There was a problem hiding this comment.
Sorry, something else came to me while I was re-reading
RobPasMue
approved these changes
Aug 26, 2024
Member
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
Thanks @klmcadams for the change!
SMoraisAnsys
approved these changes
Aug 26, 2024
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
RobPasMue
reviewed
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.