Skip to content

ci: add pull request preview action#813

Merged
Revathyvenugopal162 merged 4 commits intomainfrom
ci/add-pr-preview
Oct 8, 2025
Merged

ci: add pull request preview action#813
Revathyvenugopal162 merged 4 commits intomainfrom
ci/add-pr-preview

Conversation

@Revathyvenugopal162
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the ci Pipelines maintenance related label Oct 8, 2025
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

The documentation for this pull request will be available at https://sphinxdocs.ansys.com/pull/813. Please allow some time for the documentation to be deployed.

@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review October 8, 2025 08:51
@Revathyvenugopal162 Revathyvenugopal162 requested a review from a team as a code owner October 8, 2025 08:51
@Revathyvenugopal162 Revathyvenugopal162 self-assigned this Oct 8, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action needs to add the conditional if: github.event.action != 'closed' in every other job to avoid re-running once the pull is closed.

Revathyvenugopal162 and others added 2 commits October 8, 2025 10:59
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

On a side note.. Moving forward, could we embed this "if" behavior as part of the action itself? We could expose an input parameter for the "event-action" and skip things or run things depending on the status. What do you think?

@Revathyvenugopal162 Revathyvenugopal162 merged commit 2643574 into main Oct 8, 2025
21 checks passed
@Revathyvenugopal162 Revathyvenugopal162 deleted the ci/add-pr-preview branch October 8, 2025 09:12
@pyansys-ci-bot
Copy link
Collaborator

This PR has been closed. Documentation for this pull request will shortly be removed from its former deployment address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pipelines maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants