Skip to content

fix: skip v0 tests in v1#2603

Closed
b-matteo wants to merge 4 commits intomainfrom
fix/skip_v0_tests_in_v1
Closed

fix: skip v0 tests in v1#2603
b-matteo wants to merge 4 commits intomainfrom
fix/skip_v0_tests_in_v1

Conversation

@b-matteo
Copy link
Contributor

Description

Skip V0 tests in V1 context

Issue linked

These v0 tests were still running in V1:

  • test_design:test_old_backend_version
  • test_design:test_legacy_export_download
  • test_nurbs:test_nurbs_operations_with_old_backend
  • test_imprint_project_nurbs_old_backend
  • test_nurbs_surface_body_creation_using_old_backend
    this PR is about skipping them in V1 context

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@b-matteo b-matteo self-assigned this Feb 24, 2026
@b-matteo b-matteo requested a review from a team as a code owner February 24, 2026 13:45
@b-matteo b-matteo added the bug Something isn't working label Feb 24, 2026
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @b-matteo ! Could we avoid the code-duplication by moving the skip to the fixtures directly?

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.38%. Comparing base (942d005) to head (a21fd8d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2603      +/-   ##
==========================================
- Coverage   94.89%   90.38%   -4.52%     
==========================================
  Files         173      173              
  Lines       14441    14441              
==========================================
- Hits        13704    13052     -652     
- Misses        737     1389     +652     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue
Copy link
Member

Looking into a different mechanism for this..

@RobPasMue
Copy link
Member

This PR is not needed - the fixtures are already taking care of the skip

@RobPasMue RobPasMue closed this Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants