Skip to content

use ansys-tool-path, instead of using the env variable#116

Merged
RobPasMue merged 3 commits intoansys:mainfrom
kmahajan-cadfem:tool-path-usage
Jun 12, 2023
Merged

use ansys-tool-path, instead of using the env variable#116
RobPasMue merged 3 commits intoansys:mainfrom
kmahajan-cadfem:tool-path-usage

Conversation

@kmahajan-cadfem
Copy link
Collaborator

@kmahajan-cadfem kmahajan-cadfem commented Jun 12, 2023

updated the installer code, so that it uses ansys-tools-pathlibrary to deduce the versions that are installed, and then checks for the python that is available.

PS: I was not able to make the builds with following

on windows

  • make build
  • and then compile setup.nsis with NSIS local installaion

@RobPasMue
Copy link
Member

Hi @kmahajan-cadfem! Sounds great, thanks for opening this PR. Let me try the commands locally.

@RobPasMue
Copy link
Member

FYI @kmahajan-cadfem - see my video. Managed to run make build successfully on a clean env

video.webm

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging!

@kmahajan-cadfem
Copy link
Collaborator Author

@RobPasMue,

Thank you for the video, I did not write initial comment correctly.
sorry for confusion.

I was able to build it 👍 and also compile it, unfortunately could not run either the built exe or even the installed exe (after compiling, did the installation)

I think there maybe a step in Github actions that I did not follow, but that is fine, I wanted to make sure that it would work after installation as well.

@RobPasMue
Copy link
Member

Due to your active contributions @kmahajan-cadfem we have sent you an invitation as an outside collaborator. Feel free to accept or reject it. We want to thank you all your support! I will also add you to the contributors list if you agree. I will do that on a follow-up PR (before doing a new release).

@RobPasMue RobPasMue merged commit af6ddca into ansys:main Jun 12, 2023
@kmahajan-cadfem kmahajan-cadfem deleted the tool-path-usage branch May 26, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants