fix: ensure stable sort by normalizing localeCompare options#44
Merged
antfu merged 2 commits intoantfu:mainfrom Dec 10, 2025
Merged
fix: ensure stable sort by normalizing localeCompare options#44antfu merged 2 commits intoantfu:mainfrom
antfu merged 2 commits intoantfu:mainfrom
Conversation
✅ Deploy Preview for resonant-bonbon-a310e6 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
antfu
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
localeCompare()depends on the host environment when thelocalesargument is not provided.This caused unstable sorting results on different machines, especially for Chinese strings.
This PR fixes the issue by explicitly setting:
to ensure consistent and deterministic sorting behavior across environments.
This PR also migrates the build system from
unbuildtotsdown.