fix: Validate IP octet ranges in firewall init script#32854
Open
anshul-garg27 wants to merge 1 commit intoanthropics:mainfrom
Open
fix: Validate IP octet ranges in firewall init script#32854anshul-garg27 wants to merge 1 commit intoanthropics:mainfrom
anshul-garg27 wants to merge 1 commit intoanthropics:mainfrom
Conversation
The IP/CIDR validation regex accepts values like 999.999.999.999/99 because it only checks digit count (1-3) without verifying octets are <= 255 and prefix length is <= 32. Add arithmetic checks after the regex match using BASH_REMATCH to reject invalid addresses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.devcontainer/init-firewall.shProblem
The regex on lines 58 and 84 accepts values like
999.999.999.999/99because it only validates digit count (1-3 digits per octet) without checking the actual numeric range. Values above 255 for octets or above 32 for prefix length are invalid.Fix
After the regex match, use
BASH_REMATCHcapture groups with arithmetic comparison to verify:Test plan
bash -n init-firewall.sh192.168.1.0/24pass validation999.1.2.3/24are rejected1.2.3.4/33is rejected