Fix Docker build issues on Windows and non-ARM architectures#61
Closed
EmilLindfors wants to merge 2 commits intoanthropics:mainfrom
Closed
Fix Docker build issues on Windows and non-ARM architectures#61EmilLindfors wants to merge 2 commits intoanthropics:mainfrom
EmilLindfors wants to merge 2 commits intoanthropics:mainfrom
Conversation
This was referenced Feb 25, 2025
8enmann
previously approved these changes
Feb 25, 2025
Collaborator
8enmann
left a comment
There was a problem hiding this comment.
Thanks for the PR! Unfortunately we require signed commits so I think you'll need to rebase & force push. https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
… appropriate version of git-delta (ARM64 vs AMD64) Added a .gitattributes file to enforce LF line endings for all text files, with special attention to shell scripts Ensured script files have proper executable permissions
f633fa3 to
7bfe84f
Compare
|
@EmilLindfors I like the approach for handling amd64 and arm64, but I think this might be a safer and more dynamic solution: RUN ARCH=$(dpkg --print-architecture) && \
wget "https://github.com/dandavison/delta/releases/download/0.18.2/git-delta_0.18.2_${ARCH}.deb" && \
sudo dpkg -i "git-delta_0.18.2_${ARCH}.deb" && \
rm "git-delta_0.18.2_${ARCH}.deb"It uses What do you think? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current .devcontainer setup encounters two major issues when building on Windows or non-ARM architectures:
The Dockerfile attempts to install git-delta specifically for ARM64 architecture, causing build failures on x86_64 systems.
Windows line endings (CRLF) in shell scripts cause script execution failures within the Linux container.
Changes
Modified the Dockerfile to detect system architecture and install the appropriate version of git-delta (ARM64 vs AMD64)
Added a .gitattributes file to enforce LF line endings for all text files, with special attention to shell scripts
Ensured script files have proper executable permissions
Testing
Successfully built and ran the dev container on Windows 11 with Docker Desktop.
These changes maintain compatibility with ARM-based systems while adding support for the more common x86_64 architecture, making Claude Code more accessible to developers using standard hardware.
nb. unfortunately claude-code is at capacity so i cant test the actual application