Skip to content

Conversation

@quenio
Copy link
Contributor

@quenio quenio commented Jan 23, 2016

The second half of this table was being displayed as a paragraph.

The second half of this table was being displayed as a paragraph.
@quenio quenio changed the title Fix formatting of functions table Doc - Fix formatting of functions table Jan 23, 2016
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Consider the following:

  • Replace v with attr in the description. There are two instances in this line, and a few similar cases in other descriptions in the table.
  • Either capitalize 'Null' or change it to null.
  • Use inline code for reverse(strip(attr)). The same situation occurs in a few other descriptions as well.

@sharwell
Copy link
Member

This change does fix the formatting, so 👍 from me. If you want to address them at the same time, I left a few notes regarding some additional cleanup that would improve the documentation (IMO).

@sharwell sharwell merged commit 3ee2d1d into antlr:master Jul 20, 2017
@parrt parrt added this to the 4.0.9 milestone Nov 7, 2018
@parrt parrt removed the code review label Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants