[squid:S2095] Resources should be closed #148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Formatter f = new Formatter(locale); | ||
| f.format(formatString, o); | ||
| return f.toString(); | ||
| String str = f.toString(); |
Member
There was a problem hiding this comment.
💡 This code should be in a try/finally for exception-safe closing of the Formatter instance.
Author
|
Done |
| Formatter f = new Formatter(locale); | ||
| f.format(formatString, o); | ||
| return f.toString(); | ||
| Formatter f = null; |
Member
There was a problem hiding this comment.
💡 Slight simplification
Formatter f = new Formatter(locale);
try {
f.format(formatString, o);
return f.toString();
} finally {
f.close();
}
adding try/finally simplify code
Member
|
👍 |
Member
|
doing similarly manually 40bfd17 . closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rule
squid:S2095 - “Resources should be closed”.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S2095
Please let me know if you have any questions.
Ayman Abdelghany.