Re-enable Revapi #245
Merged
Re-enable Revapi #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cb75829
Member
|
Will this happen at each release? If so, i'm opposed to its use ;) |
Also added an ignore rule for ST.VERSION which obviously changes its constant value with every release, and Compiler.subtemplateCount which changed type in 4.2.
Contributor
Author
|
I updated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables the Revapi Maven plugin.
I tried to fix the problem that it breaks when releasing a new version by explicitly setting the
oldVersionit should compare against.I believe all that needs to be done next time is update this to the version number of the newly released version. E.g., after releasing v4.4, change<oldVersion>4.3</oldVersion>to<oldVersion>4.4</oldVersion>in a new commit. The important part is the new version needs to be available on Maven by the time this commit is made.Update: don't have to do anything any more.