Skip to content

Add null check when getting token source name #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
parrt merged 3 commits into from
Apr 21, 2020
Merged

Add null check when getting token source name #254

parrt merged 3 commits into from
Apr 21, 2020

Conversation

@steinybot
Copy link
Contributor

@steinybot steinybot commented Apr 18, 2020

Fixes #253

Clashsoft
Clashsoft suggested changes Apr 19, 2020
View reviewed changes
@parrt
Copy link
Member

parrt commented Apr 19, 2020

Hi. Also need https://github.com/antlr/stringtemplate4/blob/master/contributors.txt file signed.

@parrt parrt added the type:bug label Apr 19, 2020
@steinybot @Clashsoft
Use early return
b6120e4 
Co-Authored-By: Adrian Kunz <[email protected]>
@parrt parrt merged commit d181235 into antlr:master Apr 21, 2020
@parrt
Copy link
Member

parrt commented Apr 21, 2020

Thanks!

@steinybot steinybot deleted the fix/npe branch April 21, 2020 21:27
@eed3si9n eed3si9n mentioned this pull request Apr 24, 2020
Merged
@steinybot steinybot mentioned this pull request Jun 22, 2020
Closed
@parrt parrt added this to the 4.3.1 milestone Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Clashsoft Clashsoft Clashsoft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type:bug

Projects

None yet

Milestone

4.3.1

Development

Successfully merging this pull request may close these issues.

NullPointerException in ErrorManager.compileTimeError

3 participants

@steinybot @parrt @Clashsoft