Fix flaky FlowAggregator E2E tests#7741
Merged
antoninbas merged 1 commit intoantrea-io:mainfrom Feb 9, 2026
Merged
Conversation
petertran-avgo
force-pushed
the
topic/petertran/7740/flakey-e2e
branch
8 times, most recently
from
da6e8dd to
1852223
Compare
petertran-avgo
changed the title
antoninbas
reviewed
Feb 2, 2026
test/e2e/flowaggregator_test.go
Outdated
| t.Run(o.name, func(t *testing.T) { | ||
| var err error | ||
| data, v4Enabled, v6Enabled := setupFlowAggregatorTest(t, o.flowVisibilityTestOptions) | ||
| _, _, stderr, err := data.RunCommandOnNode(controlPlaneNodeName(), "kubectl delete pod -n kube-system -l app=antrea,component=antrea-agent --field-selector spec.nodeName="+controlPlaneNodeName()) |
Contributor
There was a problem hiding this comment.
We usually avoid running commands on the Node, instead we prefer the K8s API
However, in this case, how can we make the tests more robust without restarting Agent Pods? Would it help to call getAndCheckFlowAggregatorMetrics for each sub-test?
Contributor
Author
There was a problem hiding this comment.
I didn't notice that helper, nice! I was able to re-use it and it stabilized the tests. I also realized it is called after all the setupFlowAggregator calls so I did a small refactor as well.
petertran-avgo
force-pushed
the
topic/petertran/7740/flakey-e2e
branch
from
fb05558 to
f896705
Compare
antoninbas
reviewed
Feb 6, 2026
Contributor
antoninbas
left a comment
antoninbas
left a comment
There was a problem hiding this comment.
Sorry for the delay. The change looks good to me but I think we don't need to introduce withClickHouseExporter. Instead we could use databaseURL != "" to determine without CH is enabled, as we already use that same condition in a couple of places.
…cs (antrea-io#7740) The FlowAggregator SecureConnection tests were flaky. Flows took a long time to arrive in the FlowAggregator. When they did, it was only 1 flow instead of the expected 3. The Delta count and Total count were always equal due to the FlowExporter buffering the flow data before sending it. This was caused by the fact that FlowAggregator was redeployed for each subtest. The Agent was slow to reconnect to the freshly deployed FlowAggregator. Thus, the FlowExporter didn't match the expected timings of the tests. The test setup was updated to check FlowAggregator metrics after each redeployment. This ensures the FlowExporter has reconnected to the new FlowAggregator before testing. Signed-off-by: Peter Tran <peter-pt.tran@broadcom.com>
petertran-avgo
force-pushed
the
topic/petertran/7740/flakey-e2e
branch
from
f896705 to
7ba989b
Compare
antoninbas
approved these changes
Feb 9, 2026
Contributor
|
/test-e2e |
Contributor
Author
|
@antoninbas Thanks so much for reviewing and merging my PR. Is this worth cherry-picking to the release branches? I've been hit with this flake there too |
antoninbas
added
kind/failing-test
petertran-avgo
added a commit
to petertran-avgo/antrea
that referenced
this pull request
Feb 12, 2026
… (antrea-io#7741) The FlowAggregator SecureConnection tests were flaky. Flows took a long time to arrive in the FlowAggregator. When they did, it was only 1 flow instead of the expected 3. The Delta count and Total count were always equal due to the FlowExporter buffering the flow data before sending it. This was caused by the fact that FlowAggregator was redeployed for each subtest. The Agent was slow to reconnect to the freshly deployed FlowAggregator. Thus, the FlowExporter didn't match the expected timings of the tests. The test setup was updated to check FlowAggregator metrics after each redeployment. This ensures the FlowExporter has reconnected to the new FlowAggregator before testing. Signed-off-by: Peter Tran <peter-pt.tran@broadcom.com>
petertran-avgo
added a commit
to petertran-avgo/antrea
that referenced
this pull request
Feb 12, 2026
… (antrea-io#7741) The FlowAggregator SecureConnection tests were flaky. Flows took a long time to arrive in the FlowAggregator. When they did, it was only 1 flow instead of the expected 3. The Delta count and Total count were always equal due to the FlowExporter buffering the flow data before sending it. This was caused by the fact that FlowAggregator was redeployed for each subtest. The Agent was slow to reconnect to the freshly deployed FlowAggregator. Thus, the FlowExporter didn't match the expected timings of the tests. The test setup was updated to check FlowAggregator metrics after each redeployment. This ensures the FlowExporter has reconnected to the new FlowAggregator before testing. Signed-off-by: Peter Tran <peter-pt.tran@broadcom.com>
antoninbas
pushed a commit
that referenced
this pull request
Feb 27, 2026
#7778) The FlowAggregator SecureConnection tests were flaky. Flows took a long time to arrive in the FlowAggregator. When they did, it was only 1 flow instead of the expected 3. The Delta count and Total count were always equal due to the FlowExporter buffering the flow data before sending it. This was caused by the fact that FlowAggregator was redeployed for each subtest. The Agent was slow to reconnect to the freshly deployed FlowAggregator. Thus, the FlowExporter didn't match the expected timings of the tests. The test setup was updated to check FlowAggregator metrics after each redeployment. This ensures the FlowExporter has reconnected to the new FlowAggregator before testing. Signed-off-by: Peter Tran <peter-pt.tran@broadcom.com>
petertran-avgo
added a commit
to petertran-avgo/antrea
that referenced
this pull request
Mar 2, 2026
… (antrea-io#7741) The FlowAggregator SecureConnection tests were flaky. Flows took a long time to arrive in the FlowAggregator. When they did, it was only 1 flow instead of the expected 3. The Delta count and Total count were always equal due to the FlowExporter buffering the flow data before sending it. This was caused by the fact that FlowAggregator was redeployed for each subtest. The Agent was slow to reconnect to the freshly deployed FlowAggregator. Thus, the FlowExporter didn't match the expected timings of the tests. The test setup was updated to check FlowAggregator metrics after each redeployment. This ensures the FlowExporter has reconnected to the new FlowAggregator before testing. Signed-off-by: Peter Tran <peter-pt.tran@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flaky FlowAggregator E2E tests by confirming FlowAggregator metrics (#7740)
The FlowAggregator SecureConnection tests were flaky. Flows took a
long time to arrive in the FlowAggregator. When they did, it was only
1 flow instead of the expected 3. The Delta count and Total count were
always equal due to the FlowExporter buffering the flow data before
sending it.
This was caused by the fact that FlowAggregator was redeployed for
each subtest. The Agent was slow to reconnect to the freshly deployed
FlowAggregator. Thus, the FlowExporter didn't match the expected timings
of the tests.
The test setup was updated to check FlowAggregator metrics after each
redeployment. This ensures the FlowExporter has reconnected to the new
FlowAggregator before testing.
Closes #7740