Skip to content

Fix small window buttons not clickable in screen corners unless cursor is directly over them#76

Merged
antroids merged 2 commits intoantroids:mainfrom
numexus:fix-small-buttons
Apr 22, 2025
Merged

Fix small window buttons not clickable in screen corners unless cursor is directly over them#76
antroids merged 2 commits intoantroids:mainfrom
numexus:fix-small-buttons

Conversation

@numexus
Copy link
Copy Markdown
Contributor

@numexus numexus commented Apr 14, 2025

Before
Changing the button margins was affecting the height of the buttons, which made them unclickable at screen edges unless the cursor was directly over them.

Before

Now
This has been fixed by applying margins around the buttons instead of altering their height. Buttons are now fully clickable, even in screen corners.

After

@antroids

Resolves #74

Copy link
Copy Markdown
Owner

@antroids antroids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change!
I think we can make this change uniform for buttons heigth and width.
What do you think?

@numexus
Copy link
Copy Markdown
Contributor Author

numexus commented Apr 21, 2025

Hi! I saw the suggestion, but I think it might make the buttons feel way too spaced out especially on bigger panels where the gap gets pretty noticeable.

Instead of uniform margins on all sides, we could add a config for side-specific button margins? called "Space between buttons" to match "Space between elements" configuration. that’d make it easier to match layouts with Aurorae themes.

I have a commit ready for this approach if it's fine.

Copy link
Copy Markdown
Owner

@antroids antroids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are rigth.
There is a space between elements option, should be fine for now. There are too many options in the widget already.

Could you please decouple the WindowControlButton from root by introducing property at line 96:
property int verticalPadding: 0
and use it to pass the gaps.

@numexus
Copy link
Copy Markdown
Contributor Author

numexus commented Apr 22, 2025

done

Copy link
Copy Markdown
Owner

@antroids antroids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you!

@antroids antroids merged commit da30f12 into antroids:main Apr 22, 2025
@antsn
Copy link
Copy Markdown

antsn commented Jun 1, 2025

Hi, thank you.

However, it seems that the problem I reported has not been completely fixed.

test

In my case, as I described, the issue occurs only when the panel is on the left and the close button is positioned at the top-left of the screen. I also detailed how I arrange the buttons for that setup in my post:
#74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants